Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some failing tests around targeted dependencies #6212

Closed
wants to merge 2 commits into from

Conversation

wagenet
Copy link

@wagenet wagenet commented Oct 23, 2018

No description provided.

If specifying divergent paths is not allowed, specifying divergent
versions probably shouldn't be allowed either.
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @matklad (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@wagenet
Copy link
Author

wagenet commented Nov 8, 2018

ping @alexcrichton

@alexcrichton
Copy link
Member

Thanks for this! We can't merge failing tests, though, so perhaps this can be cc'd on the relevant issues and left as good tests for when they're fixed?

@wagenet
Copy link
Author

wagenet commented Nov 8, 2018

@alexcrichton I referenced it on #3195. Guess I should have pinged you there.

@dwijnand
Copy link
Member

Closing for now..

@dwijnand dwijnand closed this Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants