-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better build progress report #3451
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Update: documented and verbose mode are supported. Still have the line cleaning problem. |
Thanks for the PR! I'd love to improve the output of Cargo by default as I think there's definitely a lot of improvements we can make. Unfortunately I don't think we can rely on the escape codes here working across platforms, though, notably Windows. I'd also prefer to keep a consistent experience across platforms where possible. I've also prototyped this before with |
☔ The latest upstream changes (presumably #3490) made this pull request unmergeable. Please resolve the merge conflicts. |
Closing due to inactivity, but feel free to resubmit with a rebase! |
Any interest in reviving this with something using https://github.com/mitsuhiko/indicatif? |
Why not. |
Displays a one line progress of what crates are currently built. cc #2536, #3448. The change is based on #3451, but uses the progress bar introduced in #4646 instead. The percentage is simply the number of crates processed ÷ total crates count, which is inaccurate but better than nothing. Output looks like: [![asciicast](https://asciinema.org/a/YTiBAz4K4vfidNTAnehtyH46l.png)](https://asciinema.org/a/YTiBAz4K4vfidNTAnehtyH46l)
Show a finer report of what's happening while compiling. I still have to handle the errors, verbose mode, and for some reason the line is not clean before output.
See https://asciinema.org/a/9act16135ictn6zxwf97nmx9g for the output.
Closes #3448.