-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display progress when compiling dependencies #2536
Comments
When we compile with concurrent jobs don't we get the order jumbled? |
An atomic counter could be used to keep a consistent order between threads. I will look into implementing this later today. |
cc rust-lang/rust#24335, specifically rust-lang/rust#24335 (comment). I'm somewhat wary of doing this because of:
But that being said, I'd love to see progress here! Ideally we could get some form of hooks into the compiler indicating where it is and we could provide an interactive UI which indicates the progress of compilation (even concurrently), but that may be kinda difficult to implement :( |
Displays a one line progress of what crates are currently built. cc #2536, #3448. The change is based on #3451, but uses the progress bar introduced in #4646 instead. The percentage is simply the number of crates processed ÷ total crates count, which is inaccurate but better than nothing. Output looks like: [![asciicast](https://asciinema.org/a/YTiBAz4K4vfidNTAnehtyH46l.png)](https://asciinema.org/a/YTiBAz4K4vfidNTAnehtyH46l)
Wasn't this implemented with them fancy progress bars? |
Stabilize -Zcompile-progress. Closes #2536.
While it's definitely a useful feature, it has some quirks on Windows:
Apparently, there was some message which was not fully erased before been replaced with the "Downloaded 1 crates (541.8 KB) in 3.02s". Should I open a new issue for that? |
@pravic I'm able to reproduce, I can take a look. It's not windows-specific. Thanks! |
@ehuss Thanks! |
e.g.
When compiling a crate with a lot of transitive dependencies (which themselves may not be trivial), it would be nice to see about how many crates are left to compile.
The text was updated successfully, but these errors were encountered: