Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download summary overlapping progress. #6206

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Oct 22, 2018

The following two lines:

 Downloading 0 crates, extracting cargo-modules ...
  Downloaded 1 crates (541.8 KB) in 1.64s

Were being combined resulting in:

  Downloaded 1 crates (541.8 KB) in 1.64sodules ...

The following two lines:

```
 Downloading 0 crates, extracting cargo-modules ...
  Downloaded 1 crates (541.8 KB) in 1.64s
```

Were being combined resulting in:

```
  Downloaded 1 crates (541.8 KB) in 1.64sodules ...
```
@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

Nice catch!

@bors
Copy link
Contributor

bors commented Oct 22, 2018

📌 Commit f64a3be has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Oct 22, 2018

⌛ Testing commit f64a3be with merge f8000006e4f194c15da731571ec3bad07e1c540f...

@bors
Copy link
Contributor

bors commented Oct 22, 2018

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Oct 23, 2018

⌛ Testing commit f64a3be with merge 2098c96...

bors added a commit that referenced this pull request Oct 23, 2018
Fix download summary overlapping progress.

The following two lines:

```
 Downloading 0 crates, extracting cargo-modules ...
  Downloaded 1 crates (541.8 KB) in 1.64s
```

Were being combined resulting in:

```
  Downloaded 1 crates (541.8 KB) in 1.64sodules ...
```
@bors
Copy link
Contributor

bors commented Oct 23, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 2098c96 to master...

@bors bors merged commit f64a3be into rust-lang:master Oct 23, 2018
@ehuss ehuss added this to the 1.31.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants