Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer warn about #![feature(rust_2018_preview)] #6054

Merged
merged 2 commits into from
Sep 19, 2018

Conversation

steveklabnik
Copy link
Member

Backport of #6052 to 1.30

This is no longer needed, and so the warning is outdated.

Fixes rust-lang#6050
@rust-highfive
Copy link

r? @matklad

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.30.0. Please double check that you specified the right target!

@steveklabnik
Copy link
Member Author

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 18, 2018

📌 Commit f27fcf9 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Sep 19, 2018

⌛ Testing commit f27fcf9 with merge c6f8f9d4994c2140482d178c3a10bdefa34b68af...

@bors
Copy link
Contributor

bors commented Sep 19, 2018

💔 Test failed - status-appveyor

@steveklabnik
Copy link
Member Author

Hm, interesting. Looks like it's failing with minimum versions? Should we update the version of wincolor?

@alexcrichton
Copy link
Member

Ah that'll need this change as well to get past CI (unfortunately)

@steveklabnik
Copy link
Member Author

Ah, fair. done.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 19, 2018

📌 Commit bcd6ca7 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Sep 19, 2018

⌛ Testing commit bcd6ca7 with merge 308b1ea...

bors added a commit that referenced this pull request Sep 19, 2018
No longer warn about #![feature(rust_2018_preview)]

Backport of #6052 to 1.30
@bors
Copy link
Contributor

bors commented Sep 19, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 308b1ea to rust-1.30.0...

@bors bors merged commit bcd6ca7 into rust-lang:rust-1.30.0 Sep 19, 2018
@steveklabnik steveklabnik deleted the rust-1.30.0 branch September 19, 2018 02:37
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Sep 19, 2018
This pulls in rust-lang/cargo#6054, and
is a beta backport of rust-lang#54334
bors added a commit to rust-lang/rust that referenced this pull request Sep 19, 2018
@ehuss ehuss added this to the 1.30.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants