-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use raw-dylib for windows-sys #1137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ChrisDenton Seems like it doesn't work https://github.com/rust-lang/cc-rs/actions/runs/9827681479/job/27130657478?pr=1137#step:8:18
|
ChrisDenton
reviewed
Jul 7, 2024
Merged
NobodyXu
force-pushed
the
windows-sys-rar-dynlibi
branch
from
July 8, 2024 11:17
9ee3a45
to
4ea25a5
Compare
Seems that it needs msrv 1.67 rust-lang/rust#104360 (comment) |
NobodyXu
added a commit
that referenced
this pull request
Jul 8, 2024
For #1137 Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Merged
NobodyXu
added a commit
that referenced
this pull request
Jul 8, 2024
For #1137 Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
To avoid having to declare `#[link(name = "...")]` Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Co-authored-by: Chris Denton <chris@chrisdenton.dev>
NobodyXu
force-pushed
the
windows-sys-rar-dynlibi
branch
from
July 8, 2024 11:29
4ea25a5
to
02ecf8f
Compare
NobodyXu
added a commit
that referenced
this pull request
Jul 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid having to declare
#[link(name = "...")]