Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump msrv to 1.65 #1140

Merged
merged 5 commits into from
Jul 8, 2024
Merged

Bump msrv to 1.65 #1140

merged 5 commits into from
Jul 8, 2024

Conversation

NobodyXu
Copy link
Collaborator

@NobodyXu NobodyXu commented Jul 7, 2024

Required for #1137

@NobodyXu
Copy link
Collaborator Author

NobodyXu commented Jul 7, 2024

Unfortunately Debian stable is still on 1.63 https://packages.debian.org/search?keywords=rustc

@ChrisDenton
Copy link
Member

What is the actual MSRV policy currently? It's used to be roughly stable - 2. But then this crate languished for awhile so the practical MSRV slipped further through inaction. While I don't think this needs the MSRV to be as aggressive as it used to be, I'm also not sure there's much reason to have Debian LTS as a baseline, It appears they already ship a cc-rs package: https://packages.debian.org/search?suite=default&section=all&arch=any&searchon=names&keywords=librust-cc

@thomcc
Copy link
Member

thomcc commented Jul 8, 2024

I'd be fine with something like stable-5 (IIRC the libs team agreed that this would be good for libc, so I'm just cribbing from that). I know a lot of people have strong feelings about MSRV, but ancient MSRVs increase maintenance burden and we are low on those resources.

@thomcc
Copy link
Member

thomcc commented Jul 8, 2024

More concretely, 1.65 is from 2022 so it seems fine to update to that now.

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
@NobodyXu NobodyXu merged commit 0eebb31 into main Jul 8, 2024
50 checks passed
@NobodyXu NobodyXu deleted the bump-msrv branch July 8, 2024 11:11
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants