Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix failure from cargo not propagating because of pipe #1432

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

madsmtm
Copy link
Collaborator

@madsmtm madsmtm commented Mar 13, 2025

Follow-up to #1413.

Workflow run in https://github.com/rust-lang/cc-rs/actions/runs/13834048235/job/38704775630, the step fails as expected, but the error isn't visible to GitHub Actions because of the pipe to tee.

@madsmtm madsmtm added bug github_actions Pull requests that update GitHub Actions code labels Mar 13, 2025
@madsmtm madsmtm requested a review from NobodyXu March 13, 2025 13:16
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NobodyXu NobodyXu merged commit cfb6a7c into rust-lang:main Mar 13, 2025
73 checks passed
@madsmtm madsmtm deleted the fix-test-rustc-targets branch March 13, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants