Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix creating issue comment #1433

Merged
merged 2 commits into from
Mar 14, 2025
Merged

ci: fix creating issue comment #1433

merged 2 commits into from
Mar 14, 2025

Conversation

madsmtm
Copy link
Collaborator

@madsmtm madsmtm commented Mar 13, 2025

Follow-up to #1413.

I should have tested this on #1432, but I didn't know (until now) that GitHub Actions allow running workflows on branches (because they only do so if the branch is part of the upstream repo itself, while that PR was on my fork instead).

@madsmtm madsmtm added bug github_actions Pull requests that update GitHub Actions code labels Mar 13, 2025
@madsmtm madsmtm force-pushed the fix-opening-issue branch 2 times, most recently from 6d6668a to 9d15662 Compare March 13, 2025 14:33
@madsmtm madsmtm force-pushed the fix-opening-issue branch from 9d15662 to 0957a50 Compare March 13, 2025 14:33
@madsmtm
Copy link
Collaborator Author

madsmtm commented Mar 13, 2025

@madsmtm madsmtm requested a review from NobodyXu March 13, 2025 14:34
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@NobodyXu NobodyXu merged commit d2a5991 into main Mar 14, 2025
146 checks passed
@NobodyXu NobodyXu deleted the fix-opening-issue branch March 14, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants