Explicitly set static crt #31
Merged
+30
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lib.rs
Outdated
| @@ -232,13 +242,15 @@ impl Config { | |||
| .debug(false) | |||
| .target(&target) | |||
| .host(&host) | |||
| .static_crt(self.static_crt.unwrap_or(false)) | |||
There was a problem hiding this comment.
For maximal safety to trigger the None fallback logic in gcc-rs, could this only be configured if static_crt is explicitly set in cmake?
src/lib.rs
Outdated
| cxx_cfg.static_crt(static_crt); | ||
| } | ||
|
|
||
| let c_compiler = gcc::Config::new().get_compiler(); |
There was a problem hiding this comment.
Shouldn't this be using c_cfg and cxx_cfg from above?
There was a problem hiding this comment.
Oops, fixed that
|
Excellent! I'll make a release now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will help to resolve rust-lang/rust#40246