-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass static crt to llvm cmake configuration #41975
Pass static crt to llvm cmake configuration #41975
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Are the dependency updates necessary, or unrelated? |
@Mark-Simulacrum they are necessary. See rust-lang/cc-rs#159 and rust-lang/cmake-rs#31 |
Sounds good. Just making sure. |
@bors: r+ Thanks! |
📌 Commit 1163f2c has been approved by |
…-cmake-config, r=alexcrichton Pass static crt to llvm cmake configuration Solves rust-lang#40246
…-cmake-config, r=alexcrichton Pass static crt to llvm cmake configuration Solves rust-lang#40246
Solves #40246