Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass static crt to llvm cmake configuration #41975

Merged

Conversation

liranringel
Copy link
Contributor

Solves #40246

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@liranringel
Copy link
Contributor Author

?r @alexcrichton

@Mark-Simulacrum
Copy link
Member

Are the dependency updates necessary, or unrelated?

r? @alexcrichton

@liranringel
Copy link
Contributor Author

@Mark-Simulacrum they are necessary. See rust-lang/cc-rs#159 and rust-lang/cmake-rs#31

@Mark-Simulacrum
Copy link
Member

Sounds good. Just making sure.

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented May 13, 2017

📌 Commit 1163f2c has been approved by alexcrichton

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 13, 2017
…-cmake-config, r=alexcrichton

Pass static crt to llvm cmake configuration

Solves rust-lang#40246
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 14, 2017
…-cmake-config, r=alexcrichton

Pass static crt to llvm cmake configuration

Solves rust-lang#40246
bors added a commit that referenced this pull request May 14, 2017
Rollup of 7 pull requests

- Successful merges: #41612, #41826, #41939, #41946, #41950, #41975, #41979
- Failed merges:
@bors bors merged commit 1163f2c into rust-lang:master May 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants