Add function to specify build-tool generator #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -237,7 +245,9 @@ impl Config { | |||
| // On MinGW we need to coerce cmake to not generate a visual | |||
| // studio build system but instead use makefiles that MinGW can | |||
| // use to build. | |||
| cmd.arg("-G").arg("MSYS Makefiles"); | |||
| if self.generator.is_none() { | |||
| self.generator("MSYS Makefiles"); | |||
There was a problem hiding this comment.
Could this actually just pass down -G directly? In theory we don't want to do too much mutation as part of this call of the Config structure itself
|
Just a few minor nits but otherwise looks good to me! Could you also back out the version number change for now? I like to do separate standalone commits with that |
|
Thanks for the review, I've pushed a new commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for rust-lang/rust#32809