Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RISC-V Linux Tier 2 Host support #312

Closed
1 of 3 tasks
tblah opened this issue Jun 17, 2020 · 7 comments
Closed
1 of 3 tasks

RISC-V Linux Tier 2 Host support #312

tblah opened this issue Jun 17, 2020 · 7 comments
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@tblah
Copy link

tblah commented Jun 17, 2020

Proposal

Support riscv64gc-unknown-linux-gnu hosts at Tier 2. The Tier 2 support currently advertised on rust-forge is only for cross compilation.

Mentors or Reviewers

@nikomatsakis

Process

The main points of the Major Change Process is as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@tblah tblah added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Jun 17, 2020
@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2020

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jun 17, 2020
@nikomatsakis
Copy link
Contributor

OK, I'm not sure the best way to make approvals for Tier 2, but I propose that we go with FCP for now. To that end, I would like to propose to @rust-lang/compiler that we elevate RISC-V Linux to Tier 2 support. This would mean that we would check that it continues to build and that we can build it not only in cross-compiling mode but also on a RISC-V system, self-hosted.

The @rust-lang/infra team already gave their assent here. We have a proposed notification group of folks that would help with maintenance.

Moving to Tier 2 is certainly not irreversible, but it will mean that we distribute binaries with rustup, so withdrawing support would be quite noticeable. The main risk I see is that if we start getting more RISC-V specific bug reports, it will be hard for us to reproduce: but we're not committed to support at this tier, and the notification group should help with resolving such issues.

@rfcbot fcp merge

@rfcbot
Copy link
Collaborator

rfcbot commented Jun 17, 2020

Team member @nikomatsakis has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Jun 17, 2020
@nikomatsakis nikomatsakis added disposition-merge The FCP starter wants to merge this proposed-final-comment-period An FCP has been started, cast your votes and raise concerns labels Jun 18, 2020
@rfcbot
Copy link
Collaborator

rfcbot commented Jun 28, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @nikomatsakis, I wasn't able to add the final-comment-period label, please do so.

@nikomatsakis nikomatsakis added final-comment-period The FCP has started, most (if not all) team members are in agreement and removed proposed-final-comment-period An FCP has been started, cast your votes and raise concerns labels Jun 29, 2020
@rustbot

This comment has been minimized.

1 similar comment
@rustbot

This comment has been minimized.

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jun 29, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Jul 1, 2020
@rfcbot
Copy link
Collaborator

rfcbot commented Jul 8, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

psst @nikomatsakis, I wasn't able to add the finished-final-comment-period label, please do so.

@matthewjasper matthewjasper added finished-final-comment-period The FCP has finished, action upon the disposition label needs to be taken and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels Jul 8, 2020
@spastorino spastorino added major-change-accepted A major change proposal that was accepted and removed disposition-merge The FCP starter wants to merge this finished-final-comment-period The FCP has finished, action upon the disposition label needs to be taken labels Jul 9, 2020
@rustbot rustbot added the to-announce Announce this issue on triage meeting label Jul 9, 2020
@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

6 participants