RISC-V Emulated Testing #73171
Merged
RISC-V Emulated Testing #73171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will run all tests for `riscv64gc-unknown-linux-gnu` in a QEMU instance. This is based upon the armhf QEMU test image.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jfrimmel
reviewed
Jun 9, 2020
Thanks to jfrimmel for pointing this out Co-authored-by: J. Frimmel <31166235+jfrimmel@users.noreply.github.com>
|
This looks fine from a cursory glance. Thanks for sending the PR! @bors r+ |
|
📌 Commit 086eaf8 has been approved by |
bors
added
S-waiting-on-bors
3 tasks
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 20, 2020
RISC-V Emulated Testing Adds a disabled docker image on which to run RISC-V tests. Based on the armhf image. Test using ``` ./src/ci/docker/run.sh riscv64gc-linux ``` cc: @msizanoen1
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jun 20, 2020
RISC-V Emulated Testing Adds a disabled docker image on which to run RISC-V tests. Based on the armhf image. Test using ``` ./src/ci/docker/run.sh riscv64gc-linux ``` cc: @msizanoen1
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Jun 20, 2020
RISC-V Emulated Testing Adds a disabled docker image on which to run RISC-V tests. Based on the armhf image. Test using ``` ./src/ci/docker/run.sh riscv64gc-linux ``` cc: @msizanoen1
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 20, 2020
Rollup of 9 pull requests Successful merges: - rust-lang#72600 (Properly encode AnonConst into crate metadata) - rust-lang#73055 (remove leftover mentions of `skol` and `int` from the compiler) - rust-lang#73058 (Support sanitizers on aarch64-unknown-linux-gnu) - rust-lang#73171 (RISC-V Emulated Testing) - rust-lang#73404 (Update CFGuard syntax) - rust-lang#73444 (ci: disable alt build during try builds) - rust-lang#73471 (Prevent attacker from manipulating FPU tag word used in SGX enclave) - rust-lang#73539 (Deprecate `Vec::remove_item`) - rust-lang#73543 (Clean up E0695 explanation) Failed merges: r? @ghost
bjorn3
reviewed
Jun 20, 2020
| make olddefconfig && \ | ||
| make -j$(nproc) vmlinux | ||
| RUN cp linux-5.6.16/vmlinux /tmp | ||
| RUN rm -rf linux-5.6.16 |
There was a problem hiding this comment.
If you use ... && make -j$(nproc) vmlinux && cp linux-5.6.16/vmlinux /tmp && rm -rf linux-5.6.16, the linux-5.6.16 dir will not become part of the dockee image. Every RUN command creates a new overlay on top of the image as of before the RUN command. It doesn't replace it.
There was a problem hiding this comment.
@bjorn3 thanks for the reminder, I'll take a look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a disabled docker image on which to run RISC-V tests. Based on the armhf image.
Test using
cc: @msizanoen1