Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when auto-detected try build is not the latest commit #539

Closed
Aaron1011 opened this issue Sep 4, 2020 · 0 comments · Fixed by #540
Closed

Warn when auto-detected try build is not the latest commit #539

Aaron1011 opened this issue Sep 4, 2020 · 0 comments · Fixed by #540

Comments

@Aaron1011
Copy link
Member

In rust-lang/rust#76070 (comment), I accidentally started a Crater run without making a new try build. As a result, Crater ended up re-testing a previous try build on the same PR, which I mistakenly interpreted as corresponding to the latest commit.

It would be very useful if the Crater github bot showed a warning message when the commit of the auto-detected try build is not the same as the latest commit in the pull request.
@Aaron1011 Aaron1011 mentioned this issue Sep 4, 2020
Merged
bors added a commit that referenced this issue Sep 7, 2020
@bors
Auto merge of #540 - Aaron1011:feature/warn-try-build, r=pietroalbini
966d5d6 
Warn when try build SHA is mismatched

Fixes #539

If the latest commit on the PR does not match the base commit for the
detected try build, we add a warning message to the bot comment.
@bors bors closed this as completed in c865f7f Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warn when try build SHA is mismatched Aaron1011/crater
1 participant
@Aaron1011