Warn when try build SHA is mismatched #540
Merged
+45
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rust-lang#539 If the latest commit on the PR does not match the base commit for the detected try build, we add a warning message to the bot comment.
|
Thanks! @bors r+ |
|
📌 Commit c865f7f has been approved by |
|
☀️ Test successful - checks-actions |
Aaron1011
added a commit
to Aaron1011/crater
that referenced
this pull request
Jan 2, 2021
In rust-lang#540, I used the `build_sha` field to detect when the current PR head does not match the PR head used when creating the 'try' build. However, 'build_sha' corresponds to the *first* parent of the merge commit, which corresponds to the commit on the rust-lang/rust 'master' branch. We now retrieve the parents of the merge commit from GitHub, and check the first parent against the current head commit of the PR. During local testing, I had created a merge commit with the order of the parents reversed, so the check appeared to work fine for me.
bors
added a commit
that referenced
this pull request
Apr 21, 2021
Use second parent of merge commit when detecting outdated 'try' build In #540, I used the `build_sha` field to detect when the current PR head does not match the PR head used when creating the 'try' build. However, 'build_sha' corresponds to the *first* parent of the merge commit, which corresponds to the commit on the rust-lang/rust 'master' branch. We now retrieve the parents of the merge commit from GitHub, and check the first parent against the current head commit of the PR. During local testing, I had created a merge commit with the order of the parents reversed, so the check appeared to work fine for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #539
If the latest commit on the PR does not match the base commit for the
detected try build, we add a warning message to the bot comment.