Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models/default_versions: Add async fn variants #10036

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 21, 2024

I hate the duplication... but it'll be gone soon!

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 21, 2024
@Turbo87 Turbo87 merged commit f724390 into rust-lang:main Nov 21, 2024
8 checks passed
@Turbo87 Turbo87 deleted the async-default-versions branch November 21, 2024 15:32
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 89.18%. Comparing base (c9d7cbf) to head (041c456).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/models/default_versions.rs 0.00% 15 Missing ⚠️
src/bin/crates-admin/default_versions.rs 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10036      +/-   ##
==========================================
- Coverage   89.22%   89.18%   -0.04%     
==========================================
  Files         295      295              
  Lines       30836    30847      +11     
==========================================
- Hits        27514    27512       -2     
- Misses       3322     3335      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant