Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

models/default_versions: Remove sync fns #10047

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Nov 22, 2024

This PR first migrates the remaining code paths to use the async variants of the fns in the models/default_versions module, and then removes the now-unused sync functions, while also renaming the async variants and dropping the async_ prefix.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Nov 22, 2024
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 37.28814% with 37 lines in your changes missing coverage. Please review.

Project coverage is 88.94%. Comparing base (df815d7) to head (c888aff).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/bin/crates-admin/delete_version.rs 0.00% 35 Missing ⚠️
src/bin/crates-admin/default_versions.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10047      +/-   ##
==========================================
- Coverage   89.44%   88.94%   -0.51%     
==========================================
  Files         295      295              
  Lines       31475    31462      -13     
==========================================
- Hits        28154    27985     -169     
- Misses       3321     3477     +156     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@Turbo87 Turbo87 merged commit c645ab9 into rust-lang:main Nov 22, 2024
10 checks passed
@Turbo87 Turbo87 deleted the default-versions-cleanup branch November 22, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant