Actually use JSON storage for JSON data #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also never use `features` as a `HashMap<String, Vec<String>>`, so we can just pass it through from the database in a lower level representation.
|
Seems fine. The only thing I can think of this affecting is this as-yet-unimplemented feature request to display a crate's features on its page, and that would be from JSON anyway. Clarifying for anyone looking at this that this only affects getting a crate's features (per-version) into and out of the crates.io database, and does not touch the serialization to the crates.io index (which happens in git.rs. bors: r+ |
Build failed |
|
Failure is legit. I will fix when the baby stops screaming bloody murder
…On Wed, Jan 24, 2018 at 7:00 PM bors-voyager[bot] ***@***.***> wrote:
Build failed
- continuous-integration/travis-ci/push
<https://travis-ci.org/rust-lang/crates.io/builds/333076059?utm_source=github_status&utm_medium=notification>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1237 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABdWK3njMdqfqOQKI_Ytt0zUj7tfxuJ4ks5tN-AsgaJpZM4RjT7n>
.
|
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Jul 2, 2018
1237: Actually use JSON storage for JSON data r=carols10cents We also never use `features` as a `HashMap<String, Vec<String>>`, so we can just pass it through from the database in a lower level representation. 1439: Bump `env_logger` r=carols10cents 1441: `dyn` all the things r=carols10cents `#![deny(bare_trait_objects)]` is added and all existing trait objects are documented with the `dyn` keyword.
Build succeeded |
Turbo87
added
C-internal 🔧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also never use
featuresas aHashMap<String, Vec<String>>, so wecan just pass it through from the database in a lower level
representation.