dyn all the things
#1441
Merged
dyn all the things
#1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#![deny(bare_trait_objects)]` is added and all existing trait objects are documented with the `dyn` keyword.
|
Looks like this needs a ci update |
|
Yeah, looks like the clippy update in #1440 will need to be merged first. I don't see these errors locally on a newer clippy. |
|
bors: r+ |
bors-voyager bot
added a commit
that referenced
this pull request
Jul 2, 2018
1237: Actually use JSON storage for JSON data r=carols10cents We also never use `features` as a `HashMap<String, Vec<String>>`, so we can just pass it through from the database in a lower level representation. 1439: Bump `env_logger` r=carols10cents 1441: `dyn` all the things r=carols10cents `#![deny(bare_trait_objects)]` is added and all existing trait objects are documented with the `dyn` keyword.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#![deny(bare_trait_objects)]is added and all existing trait objectsare documented with the
dynkeyword.