Skip to content

Use insta for API tests #2949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Use insta for API tests #2949

wants to merge 2 commits into from

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Oct 22, 2020

see https://github.com/mitsuhiko/insta

This should hopefully make it easier to write more integration tests for our API in the future :)

r? @jtgeibel

@Turbo87 Turbo87 changed the title Use insta for API tests WIP: Use insta for API tests Oct 25, 2020
@bors
Copy link
Contributor

bors commented Oct 26, 2020

☔ The latest upstream changes (presumably #2961) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@bors
Copy link
Contributor

bors commented Nov 2, 2020

☔ The latest upstream changes (presumably #2993) made this pull request unmergeable. Please resolve the merge conflicts.

Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:

@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

@Turbo87 Turbo87 marked this pull request as draft December 3, 2020 14:32
@Turbo87 Turbo87 changed the title WIP: Use insta for API tests Use insta for API tests Dec 7, 2020
@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Feb 11, 2021
@Turbo87 Turbo87 closed this Mar 1, 2021
@Turbo87 Turbo87 deleted the insta branch September 14, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants