Use clap for CLI argument parsing
#2993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtgeibel
requested changes
Nov 2, 2020
JohnTitor
reviewed
Nov 2, 2020
Cargo.toml
Outdated
| @@ -34,6 +34,7 @@ base64 = "0.13" | |||
| cargo-registry-s3 = { path = "src/s3", version = "0.2.0" } | |||
| chrono = { version = "0.4.0", features = ["serde"] } | |||
| civet = "0.12.0-alpha.4" | |||
| clap = "3.0.0-beta.2" | |||
There was a problem hiding this comment.
Suggested change
| clap = "3.0.0-beta.2" | |
| clap = "=3.0.0-beta.2" |
I'd pin the version since clap often introduces breaking changes in beta releases (https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) and we could avoid updating it by mistake.
There was a problem hiding this comment.
Sounds reasonable. I've changed it to pinned. 👍
|
@bors r=jtgeibel |
|
📌 Commit c1bc624 has been approved by |
|
☀️ Test successful - checks-travis |
This was referenced Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to convert these binaries to clap subcommands in a follow-up PR. It also simplifies our argument parsing code and generates help messages and proper errors if the passed arguments don't match our expectations.
r? @jtgeibel