Skip to content

fix data manipulation for download graph #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 3, 2016

Conversation

TyOverby
Copy link
Contributor

@TyOverby TyOverby commented Sep 2, 2016

No description provided.

@TyOverby TyOverby changed the title fix data manipulation for download graph [DO NOT MERGE] fix data manipulation for download graph Sep 2, 2016
@frewsxcv
Copy link
Member

frewsxcv commented Sep 2, 2016

not ok 19 PhantomJS 1.9 - JSCS - components/download-graph.js: should pass jscs
    ---
        actual: >
            false
        expected: >
            true
        stack: >
                at http://localhost:7357/assets/test-support.js:3357
                at http://localhost:7357/assets/tests.js:225
                at runTest (http://localhost:7357/assets/test-support.js:2662)
                at http://localhost:7357/assets/test-support.js:2647
                at http://localhost:7357/assets/test-support.js:2810
                at process (http://localhost:7357/assets/test-support.js:2486)
                at begin (http://localhost:7357/assets/test-support.js:2468)
                at http://localhost:7357/assets/test-support.js:3238
        message: >
            components/download-graph.js should pass jscs.
            disallowSpaceBeforeSemicolon: Illegal space before semicolon at components/download-graph.js :
                33 |            // End before the last element is reached because we never
                34 |            // want to change the last element.
                35 |            for (let i = 1; i < data.length - 1 ; i++) {
            -------------------------------------------------------^
                36 |                // k + 1 because the first entry in the array is the date
                37 |                let value = data[i][k];
        Log: |
    ...

@alexcrichton alexcrichton merged commit df1ab65 into rust-lang:master Sep 3, 2016
@alexcrichton
Copy link
Member

Thanks @TyOverby!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants