Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create db-dump.zip file too #8748

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Create db-dump.zip file too #8748

merged 2 commits into from
Jun 1, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented May 28, 2024

Zip files use compression per file, which allows users to only extract the data that they need, instead of needlessly extracting the full tarball to read the small table that they are interested in.

Resolves #2078

@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-backend ⚙️ labels May 28, 2024
@Turbo87 Turbo87 requested a review from a team May 28, 2024 14:56
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 90.16393% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 88.66%. Comparing base (1967652) to head (c137ccc).

Files Patch % Lines
src/worker/jobs/dump_db.rs 88.37% 10 Missing ⚠️
src/storage.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8748      +/-   ##
==========================================
+ Coverage   88.64%   88.66%   +0.02%     
==========================================
  Files         276      276              
  Lines       27557    27643      +86     
==========================================
+ Hits        24427    24511      +84     
- Misses       3130     3132       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eth3lbert
Copy link
Contributor

Zip files use compression per file, which allows users to only extract the data that they need, instead of needlessly extracting the full tarball to read the small table that they are interested in.

Actually, I think this could be achieved using --wildcards (or --include on mac) which only processes files matching the provided pattern.

e.g. tar -zxvf tmp/db-dump.tar.gz --include '*.sql'

@Turbo87
Copy link
Member Author

Turbo87 commented May 29, 2024

@eth3lbert yeah, that invocation might work, but the whole file still has to be decompressed by gzip before you can access the individual files inside the tarball. with a zip file you don't have to decompress the whole archive if you want to access just one file.

@17351269

This comment was marked as spam.

Zip files use compression per file, which allows users to only extract the data that they need, instead of needlessly extracting the full tarball to read the small table that they are interested in.
Copy link
Contributor

@LawnGnome LawnGnome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤐

@Turbo87 Turbo87 merged commit 57ecf88 into rust-lang:main Jun 1, 2024
10 checks passed
@Turbo87 Turbo87 deleted the zip-dump branch June 1, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Data dumps feedback
4 participants