crates-io: Add support for db-dump.zip files
#421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdno
requested changes
Jun 5, 2024
| noncurrent_version_expiration { | ||
| days = 1 | ||
| } | ||
| } |
There was a problem hiding this comment.
I'd like to avoid the duplication here. Can we use a dynamic block for this instead?
dynamic "lifecycle_rule" {
for_each = toset(["db-dump.tar.gz", "db-dump.zip"])
content {
id = "purge-${replace(lifecycle_rule.key, ".", "-")}"
enabled = true
prefix = lifecycle_rule.key
abort_incomplete_multipart_upload_days = 1
noncurrent_version_expiration {
days = 1
}
}
}There was a problem hiding this comment.
Can we use a dynamic block for this instead?
you tell me, I have no idea how to check if this works or not 😂
There was a problem hiding this comment.
Sorry, let me rephrase the question. Can you please change it to a dynamic block? 😂 I already tested that the code above works.
jdno
added a commit
to jdno/rust-simpleinfra
that referenced
this pull request
Jun 10, 2024
crates.io will start offering the database dump as a ZIP file, for which support in the CDN was merged in rust-lang#421.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see rust-lang/crates.io#8748