You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #873 added the scroll-padding-top property to ensure the topbar wouldn't cover body content. It also added a JS workaround because scroll-padding-top was not yet supported on latest Safari. Now it is. I propose to remove the JS workaround. That will also fix #1334.
Also, there's a newer alternative to position: sticky: position: fixed: https://developer.mozilla.org/en-US/docs/Web/CSS/position. It's available on all our supported browsers. The difference is that a position: sticky element participates in the DOM layout, and then transitions to fixed position once you scroll far enough. This makes it less fragile to layout the items below the sticky one, since you don't have to give everything a top offset. I propose to switch to position: sticky for the topbar.
The text was updated successfully, but these errors were encountered:
PR #873 added the
scroll-padding-top
property to ensure the topbar wouldn't cover body content. It also added a JS workaround becausescroll-padding-top
was not yet supported on latest Safari. Now it is. I propose to remove the JS workaround. That will also fix #1334.Also, there's a newer alternative to
position: sticky
:position: fixed
: https://developer.mozilla.org/en-US/docs/Web/CSS/position. It's available on all our supported browsers. The difference is that aposition: sticky
element participates in the DOM layout, and then transitions to fixed position once you scroll far enough. This makes it less fragile to layout the items below the sticky one, since you don't have to give everything atop
offset. I propose to switch toposition: sticky
for the topbar.The text was updated successfully, but these errors were encountered: