Switch from position: fixed to sticky #1597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to remove `padding-top: $top-navbar-height !important` on body. Also, remove an obsolete workaround for older Chrome browsers to put scroll-padding-top on `body` rather than `html`.
syphar
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
Jan 16, 2022
|
Changes look good. I'll try it locally as soon as possible. |
|
thanks @GuillaumeGomez Please comment here when the local test is fine, then I'll merge/deploy |
|
Just checked locally and the footer is not where it should be (you can see it much better in the second image):
Normally, the footer should be stuck on the bottom of the page. |
syphar
added
S-waiting-on-author
syphar
requested changes
Jan 16, 2022
|
Fixed! Satisfyingly, the answer was additional simplification. :-) |
syphar
added
S-waiting-on-review
GuillaumeGomez
approved these changes
Jan 16, 2022
|
This time it's all good, thanks! |
syphar
added
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to remove
padding-top: $top-navbar-height !importanton body.Also, remove an obsolete workaround for older Chrome browsers to put scroll-padding-top on
bodyrather thanhtml.Part of #1595
Tested locally with latest Chrome on Desktop in Dev Tools mobile mode, and latest Chrome on latest Android.