Remove JS workaround for scroll-padding-top #1596
Conversation
Safari didn't previously support it, put it is now supported since version 14 (latest is 15).
syphar
added
the
S-waiting-on-review
|
@GuillaumeGomez does this approval also include a local test? or is it not needed here? (to know if I can merge and deploy this) |
|
I don't have an ipad or an iphone so I can't test locally. I just approved the change in itself. |
|
Can one of you explain the effect of this change so I can test it? |
|
The effect of this change should be nothing- this is a workaround (#873) that's not needed anymore. If I was incorrect in my evaluation that the workaround was not needed anymore, the effect would be: clicks on internal links (e.g. methods in the sidebar) result in the target item being partially covered by the topbar. |
|
Oh and one visible change: the "Uncaught TypeError" described in the title of #1334 should go away, on all browsers. |
I was about to fix it. Glad you're removing this code. :) |
syphar
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Safari didn't previously support it, put it is now supported since version 14 (latest is 15).
Fixes #1334. Related: #1595.
I've tested locally with latest Safari on iPad and iPhone.