docs.rs reports 404s for internal server errors

[jyn514]

Originally found in #784.

If we encounter an error in impl Handler for CratesfyiHandler, we always return the first error even if it was a 404, ignoring all future errors. This hides panics/errors and makes things very hard to debug (I have a suspicion #800 is because of an internal error being hidden by this bug).

Relevant code:

docs.rs/src/web/mod.rs

Line 140 in 9bd032f

fn handle(&self, req: &mut Request) -> IronResult<Response> {

[Kixiron]

Something that could help with identifying more errors would be adding log::error!("called ctry on an Err value: {} {}:{}", file!(), line!(), column!()) to these three macros, then we'd at least have a log of invocation locations and specific errors (where applicable)

docs.rs/src/web/mod.rs

Lines 9 to 44 in 9bd032f

	macro_rules! ctry {
	($result:expr) => {
	match $result {
	Ok(v) => v,
	Err(e) => {
	return $crate::web::page::Page::new(format!("{:?}", e))
	.title("An error has occured")
	.set_status(::iron::status::BadRequest)
	.to_resp("resp");
	}
	}
	};
	}
	/// cexpect will check an option and if it's not Some
	/// it will return an error page response
	macro_rules! cexpect {
	($option:expr) => {
	match $option {
	Some(v) => v,
	None => {
	return $crate::web::page::Page::new("Resource not found".to_owned())
	.title("An error has occured")
	.set_status(::iron::status::BadRequest)
	.to_resp("resp");
	}
	}
	};
	}
	/// Gets an extension from Request
	macro_rules! extension {
	($req:expr, $ext:ty) => {
	cexpect!($req.extensions.get::<$ext>())
	};
	}

[jyn514]

That helps with debugging, but still returns a 404 incorrectly.