Fix 404 on /releases/feed #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Kixiron
reviewed
May 29, 2020
| fn release_feed() { | ||
| wrapper(|env| { | ||
| let web = env.frontend(); | ||
| assert_success("/releases/feed", web) |
There was a problem hiding this comment.
Can we also add tests for the content by adding fake releases? This can be done in a followup PR though.
There was a problem hiding this comment.
Yes, I'll add that in a follow-up.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handlebars removed the
obj[0]notation in 0.25: sunng87/handlebars-rust@779df98#diff-e0934bb6f70a4f8c3baf22a773c14ec7L35Closes #782
r? @Kixiron
This also uncovered that we handle failure pretty badly in
impl Handler for CratesfyiHandler, we always return the first error encountered even if it was a 404, ignoring all future errors. This should be fixed, but I want to get this fix in first.