Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top banner hiding text #465

Merged
merged 2 commits into from
Nov 2, 2019
Merged

Conversation

GuillaumeGomez
Copy link
Member

I don't know what happened with the CSS formatting so I fixed it... But the important commit is the second one: it prevents text to go under the top banner. For example: https://docs.rs/halt/0.3.0/halt/struct.Invalid.html#implementations, the title won't "disappear" under the banner.

cc @pietroalbini

@jyn514
Copy link
Member

jyn514 commented Nov 2, 2019

I didn't even realize this was a problem with docs.rs, I thought firefox was being wacky. Thanks for fixing this!

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great besides this one nit!

@@ -13,12 +13,13 @@ html, button, input, select, textarea,

div.rustdoc {
font-family: "Source Serif Pro", Georgia, Times, "Times New Roman", serif;
padding: 10px 15px 20px 15px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like taking out this 'padding' style makes the search bar overlap with the style button, at least in my browser.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh funny. Can you open an issue about this (and maybe even a PR?). I don't want to mix more things in this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand, do you mean in the main rust repo? If you just add the padding back in (like it was before) it works fine.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh crap! Completely missed the fact that I removed it. Good catch! Sorry for not understanding at first.

@jyn514 jyn514 mentioned this pull request Nov 2, 2019
@GuillaumeGomez
Copy link
Member Author

@jyn514 I have put back what I mistakenly removed.

@jyn514 jyn514 merged commit da03812 into rust-lang:master Nov 2, 2019
@jyn514
Copy link
Member

jyn514 commented Nov 2, 2019

Great, thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants