-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix top banner hiding text #465
Conversation
I didn't even realize this was a problem with docs.rs, I thought firefox was being wacky. Thanks for fixing this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great besides this one nit!
@@ -13,12 +13,13 @@ html, button, input, select, textarea, | |||
|
|||
div.rustdoc { | |||
font-family: "Source Serif Pro", Georgia, Times, "Times New Roman", serif; | |||
padding: 10px 15px 20px 15px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh funny. Can you open an issue about this (and maybe even a PR?). I don't want to mix more things in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand, do you mean in the main rust repo? If you just add the padding back in (like it was before) it works fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh crap! Completely missed the fact that I removed it. Good catch! Sorry for not understanding at first.
33527fe
to
60ded3b
Compare
@jyn514 I have put back what I mistakenly removed. |
Great, thanks so much! |
I don't know what happened with the CSS formatting so I fixed it... But the important commit is the second one: it prevents text to go under the top banner. For example: https://docs.rs/halt/0.3.0/halt/struct.Invalid.html#implementations, the title won't "disappear" under the banner.
cc @pietroalbini