Skip to content

Extend size of :targeted elements #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

TooManyBees
Copy link

When the browser follows a link with a #fragment, it scrolls up or
down to put the element with the matching id attribute at the top
of the window. In rustdoc output, that's usually section headers.

docs.rs's floating top navbar hides that element. This PR extends
the height of the element the browser is scrolling to, in a way that
doesn't affect its visual appearance, so that it lands below the
navbar and is visible to the user.

When the browser follows a link with a `#fragment`, it scrolls up or
down to put the element with the matching `id` attribute at the top
of the window. In rustdoc output, that's usually section headers.

docs.rs's floating top navbar hides that element. This PR extends
the height of the element the browser is scrolling to, in a way that
doesn't affect its visual appearance, so that it lands below the
navbar and is visible to the user.
@GuillaumeGomez
Copy link
Member

It actually has already been fixed in #465. But for some reasons, the style.css file we get when browsing docs.rs is an older one...

cc @pietroalbini

@jyn514
Copy link
Member

jyn514 commented Nov 27, 2019

@TooManyBees This should have been fixed in #496, can you take a look at the deployed site (e.g. https://docs.rs/parze/0.5.1/parze/also/trait.Also.html#tymethod.also) and make sure it looks good? If so I'll close this.

@TooManyBees
Copy link
Author

i guess it's already fixed then

@jyn514 jyn514 closed this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants