Remove duplicate default target (redux) #550
Conversation
jyn514
force-pushed
the
one-default-target
branch
from
7378912 to
3197b85
Compare
|
There are merge conflicts. |
|
...and it'd be nice to add tests, at least for the web part. |
Yeah ... I tried to rebase, but it didn't work very well, I think because of the commit to master reverting the earlier changes. I'll fix the conflicts (again) once I've written some tests, probably tomorrow. |
|
So ... I can add tests for the web changes once #553 is merged (it has the |
I'd not handle builds along with other tests in the codebase, but I'd do something separate (like rustwide's buildtest or crater's minicrater). My worry with adding built tests along with the other tests is that it encourages using a "fake build" around the codebase tests: builds are inheritely slow, as the rustwide initialization can't be parallelized, so we want to have as few of them as possible. |
jyn514
force-pushed
the
one-default-target
branch
from
3197b85 to
12c34c8
Compare
jyn514
changed the title
|
This is ready for review. |
The code as of the previous commit would let you navigate away from the default, but not navigate back. This adds the default target to `successful_targets` to add a link to the dropdown in 'Platform'. After adding that, the link would give a 404 (because we treat paths literally when sending them to the database), so the metadata for every crate now has to include the default target, which allows redirecting to /:crate/:version/:module/ when visiting /:crate/:version/:module/:default-target
this required a bit of a rearchitecture
also uses a constant instead of hardcoding the default target
Only the default build should be in target/doc.
Column 5 was the files, not the default target :( We really need a test suite.
it's been bugging me
jyn514
force-pushed
the
one-default-target
branch
from
469b082 to
30de0e6
Compare
|
Addressed review comments. |
Same as #534 but now it doesn't crash when viewing source code.
r? @pietroalbini