Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix occasional panic when visiting settings.html #553

Merged
merged 13 commits into from
Jan 20, 2020
Merged

Fix occasional panic when visiting settings.html #553

merged 13 commits into from
Jan 20, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jan 8, 2020

Closes #552

@jyn514
Copy link
Member Author

jyn514 commented Jan 8, 2020

My only concern is about other pages besides settings.html being one directory too high, but my thought is at least now we'll see them in the traceback as opposed to having to guess.

@jyn514 jyn514 force-pushed the delete-the-panic-button branch from e109b43 to 414b730 Compare January 9, 2020 01:47
@jyn514
Copy link
Member Author

jyn514 commented Jan 9, 2020

Added tests :)

@jyn514 jyn514 force-pushed the delete-the-panic-button branch from 414b730 to 2cc3e32 Compare January 9, 2020 01:50
@jyn514 jyn514 mentioned this pull request Jan 9, 2020
Merged
pietroalbini
pietroalbini requested changes Jan 9, 2020
View reviewed changes
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested the code locally yet, but here are some comments about the test infra.

@jyn514 jyn514 force-pushed the delete-the-panic-button branch from 9077269 to f0176eb Compare January 9, 2020 12:42
@jyn514
Copy link
Member Author

jyn514 commented Jan 9, 2020 •
edited
Loading

This is ready for another review.

It's mostly commit-by-commit. The actual fix is 2cc3e32, the rest is just test infrastructure.

@jyn514 jyn514 requested a review from pietroalbini January 9, 2020 14:46
@pietroalbini pietroalbini removed their request for review January 10, 2020 11:27
@pietroalbini pietroalbini self-assigned this Jan 10, 2020
pietroalbini
pietroalbini requested changes Jan 10, 2020
View reviewed changes
Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to test the code locally, here is another thing we could improve.

@jyn514 jyn514 force-pushed the delete-the-panic-button branch from 79fd814 to dd6d871 Compare January 11, 2020 19:46
@jyn514
Copy link
Member Author

jyn514 commented Jan 13, 2020 •
edited
Loading

This is ready for review (but is no longer commit-by-commit).

@pietroalbini
Copy link
Member

The code looks good, but I don't have time to test it locally :(

@jyn514
Copy link
Member Author

jyn514 commented Jan 19, 2020

If you like, you could give me a laundry list of things to test locally and I can do it for you?

@pietroalbini pietroalbini merged commit fc011ef into rust-lang:master Jan 20, 2020
@jyn514 jyn514 deleted the delete-the-panic-button branch January 20, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietroalbini pietroalbini pietroalbini approved these changes

Assignees

@pietroalbini pietroalbini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic in path_for_latest
2 participants
@jyn514 @pietroalbini