Ask people to test the new uniform paths variant when transitioning #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Seems travis is unhappy :( |
|
@Centril Looks like it's going to be unhappy until nightly has the feature available, which is probably a good thing. |
|
@joshtriplett Indeed; The changes themselves look mostly good but I'll do a quick review since it's no rush :) |
Centril
reviewed
Aug 15, 2018
| @@ -43,6 +43,18 @@ require a Cargo.toml change to enable (described in the sections below). Also | |||
| note that during the time the preview is available, we may continue to add/enable | |||
| new features with this flag! | |||
|
|
|||
| For Rust 2018 edition preview 2, we're also testing a [new module path | |||
| variant](rust-2018/path-clarity.html), "uniform paths", which we'd like to get | |||
There was a problem hiding this comment.
"uniform paths" -> uniform_paths
| your `lib.rs` or `main.rs`: | ||
|
|
||
| ```rust | ||
| #![feature(rust_2018_preview,uniform_paths)] |
There was a problem hiding this comment.
Comma between the features.
| @@ -19,6 +19,10 @@ sections call out the differences between the two. We encourage testing of the | |||
| new "uniform paths" variant introduced in edition preview 2. The release of | |||
| Rust 2018 will stabilize one of these two variants and drop the other. | |||
|
|
|||
| To test Rust 2018 with the new "uniform paths" variant, put | |||
| `#![feature(rust_2018_preview,uniform_paths)]` at the top of your `lib.rs` or | |||
| @@ -19,6 +19,10 @@ sections call out the differences between the two. We encourage testing of the | |||
| new "uniform paths" variant introduced in edition preview 2. The release of | |||
| Rust 2018 will stabilize one of these two variants and drop the other. | |||
|
|
|||
| To test Rust 2018 with the new "uniform paths" variant, put | |||
There was a problem hiding this comment.
"uniform paths" -> uniform_paths
|
Passes Travis now. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.