Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask people to test the new uniform paths variant when transitioning #85

Merged
merged 2 commits into from
Aug 15, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/editions/transitioning-your-code-to-a-new-edition.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,18 @@ require a Cargo.toml change to enable (described in the sections below). Also
note that during the time the preview is available, we may continue to add/enable
new features with this flag!

For Rust 2018 edition preview 2, we're also testing a [new module path
variant](rust-2018/path-clarity.html), "uniform paths", which we'd like to get
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"uniform paths" -> uniform_paths

further testing and feedback on. Please try it out, by adding the following to
your `lib.rs` or `main.rs`:

```rust
#![feature(rust_2018_preview,uniform_paths)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma between the features.

```

The release of Rust 2018 will stabilize one of the two module path variants and
drop the other.

[status]: 2018/status.html

## Fix edition compatibility warnings
Expand Down
4 changes: 4 additions & 0 deletions src/rust-2018/path-clarity.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ sections call out the differences between the two. We encourage testing of the
new "uniform paths" variant introduced in edition preview 2. The release of
Rust 2018 will stabilize one of these two variants and drop the other.

To test Rust 2018 with the new "uniform paths" variant, put
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"uniform paths" -> uniform_paths

`#![feature(rust_2018_preview,uniform_paths)]` at the top of your `lib.rs` or
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comma :)

`main.rs`.

Here's a brief summary:

* `extern crate` is no longer needed
Expand Down