Broken no_std build #1396
Comments
Merged
taiki-e
added a commit
to taiki-e/futures-rs
that referenced
this issue
Jan 10, 2019
This allows build fail until rust-lang#1396 is fixed.
taiki-e
added a commit
to taiki-e/futures-rs
that referenced
this issue
Jan 10, 2019
This allows build fail until rust-lang#1396 is fixed.
taiki-e
added a commit
to taiki-e/futures-rs
that referenced
this issue
Jan 11, 2019
This allows build fail until rust-lang#1396 is fixed.
Merged
cramertj
pushed a commit
that referenced
this issue
Jan 14, 2019
This allows build fail until #1396 is fixed.
|
I have an idea for a hacky solution to this, I'll try and get a PR up soon. |
This was referenced Feb 16, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to changes from #1388 + #1390. Before the change in #1390 the tests on CI passed because they use
cargo test --all --all-features, this would activate thefutures-test/stdfeature while running thefuturestests; but if you want to run just thefuturestests locally withcargo test -p futures-previewthey would fail because thefutures-test/stdfeature was not activated. Removingdefault-featuresfalse from thefutures-testdev-dependency infuturesfixed this so that both ways of testing would work, but because of feature unification between dev and non-dev dependencies this results in thefutures-core/stdfeature being force activated always.I don't see any way to fix this with how features currently work in Cargo, but there's been no real movement on un-unifying the features of dependency types (rust-lang/cargo#4866).
The text was updated successfully, but these errors were encountered: