Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no_std build #1456

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Fix no_std build #1456

merged 2 commits into from
Feb 19, 2019

Conversation

Nemo157
Copy link
Member

@Nemo157 Nemo157 commented Feb 19, 2019 •
edited
Loading

Fixes #1396

@Nemo157
Copy link
Member Author

Nemo157 commented Feb 19, 2019 •
edited
Loading

This is based off #1445, hopefully GitHub will strip those commits once it's merged... I was hoping to provide a comparison link until then but it doesn't look like cross-fork compare pages work EDIT: turns out direct commit hashes work, here's the actual changes from this MR.

The last two commits are pretty simple, but that workaround to test the no_std build is not the nicest... it's the only solution I could think of until Cargo's handling of features across normal and dev dependencies is improved.

@Nemo157
Copy link
Member Author

Nemo157 commented Feb 19, 2019

No auto-update ☹️ re-rebased onto master.

@cramertj
Copy link
Member

LGTM-- will merge once travis is happy

@cramertj cramertj merged commit f7e5f64 into rust-lang:master Feb 19, 2019
@Nemo157 Nemo157 deleted the fix-no-std-build-w-wakers branch February 19, 2019 23:18
@taiki-e taiki-e mentioned this pull request Oct 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nemo157 @cramertj