-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ready! macro to futures-core from futures-util #1698
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think this macro is stable enough, and I think it makes sense that it is in the futures-core (this macro only depend on
core::task
. Also some crates which doesn't depend on futures-util redefine this macro).The concern was that
Poll
could be changed to not implementTry
trait (rust-lang/rust#59725 (comment)), but this cannot happen asfutures_api
has already stabilized.Refs:
std::future
. tokio-rs/tokio#1120 (comment)futures_util::macros::poll
).try_poll!
macro)try_ready!
)The text was updated successfully, but these errors were encountered: