Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove try_ready! macro #1602

Merged
merged 1 commit into from
May 14, 2019
Merged

Remove try_ready! macro #1602

merged 1 commit into from
May 14, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented May 12, 2019

Poll implements the Try trait, so we can use the ? operator and ready! macro to do the equivalent of try_ready! macro.

Actually, ready! + ? operator is more powerful than try_ready! because it also can be used in functions that return Poll<Option<Result>>. (Also, Result + ? can be used in functions that return Poll<Result> and Poll<Option<Result>> as well.)

I think it is not a problem to remove try_ready!, and it may also rather increase code consistency.

Related: #1599, #1572

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants