-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Tokio to use std::future
.
#1120
Conversation
tokio-io/src/async_write.rs
Outdated
impl<T: ?Sized + AsyncWrite> AsyncWrite for Box<T> { | ||
fn shutdown(&mut self) -> Poll<(), std_io::Error> { | ||
(**self).shutdown() | ||
impl<T: ?Sized + Unpin + AsyncWrite> AsyncWrite for Box<T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crazy nit, but maybe the AsyncX
and Unpin
should be sorted in a consistent order?
I noticed that |
@quininer I have not been following developments in the futures crate nor am I aware of any of their intent w.r.t. Tokio. As of now, I intend to keep things in Tokio. Once things settle, we can evaluate. |
I think we should establish contact with |
Perhaps it's best to first convert to what the They must be suitable, otherwise these conversions for io and streams wouldn't have been possible. |
@quininer Yes, With respect to |
Equivalent utilities will be re-introduced in other crates.
I think we can move |
@taiki-e Sounds good to me! |
} | ||
} | ||
|
||
// ===== impl Read / Write for &'a ===== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were these removed?
Remove usage of 0.1 futures and switch to
std::future
.Work in progress. Additional changes will be submitted via PRs to this branch.