Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add previously removed async-await-preview feature #1097

Closed
wants to merge 1 commit into from

Conversation

dvic
Copy link
Sponsor

@dvic dvic commented May 18, 2019

Motivation

Fixes #1094 (I assume the removal of the async-await-preview feature was a mistake?)

Solution

Revert the removal of the async-await-preview feature.

@Empty2k12
Copy link

It seems like it was not a mistake: 475dabe

@dvic
Copy link
Sponsor Author

dvic commented May 20, 2019

@Empty2k12 I read that commit message as it being removed from the 0.1.x branch, but I guess it should be included for 0.2.x?

@hawkw
Copy link
Member

hawkw commented May 24, 2019

Hi @dvic, the issue that was breaking the FreeBSD CI build was fixed in PR #1106, if you rebase your branch onto master, your build should now pass!

@dvic dvic force-pushed the async-await-preview-feature-fix branch from 49bf959 to ca44bb6 Compare May 25, 2019 17:48
@dvic
Copy link
Sponsor Author

dvic commented May 25, 2019

@hawkw done, thanks 👍

@carllerche
Copy link
Member

The 0.1 branch started lagging behind. We are working on a full updated here #1120.

@carllerche carllerche closed this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async-await-preview feature missing in master.
4 participants