Fix TCP poll_hup test #1106
Merged
Fix TCP poll_hup test #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates tests to track a fix applied in Mio. Previously, Mio incorrectly fired HUP events. This was due to Mio mapping `RDHUP` to HUP. The test is updated to correctly generate a HUP event. Additionally, HUP events will be removed from all platforms except for Linux. This is caused by the inability to reliably map kqueue events to the epoll HUP behavior.
This was referenced May 24, 2019
Closed
LucioFranco
pushed a commit
to LucioFranco/tokio
that referenced
this pull request
May 28, 2019
This updates tests to track a fix applied in Mio. Previously, Mio incorrectly fired HUP events. This was due to Mio mapping `RDHUP` to HUP. The test is updated to correctly generate a HUP event. Additionally, HUP events will be removed from all platforms except for Linux. This is caused by the inability to reliably map kqueue events to the epoll HUP behavior.
LucioFranco
pushed a commit
to LucioFranco/tokio
that referenced
this pull request
May 29, 2019
This updates tests to track a fix applied in Mio. Previously, Mio incorrectly fired HUP events. This was due to Mio mapping `RDHUP` to HUP. The test is updated to correctly generate a HUP event. Additionally, HUP events will be removed from all platforms except for Linux. This is caused by the inability to reliably map kqueue events to the epoll HUP behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates tests to track a fix applied in Mio. Previously, Mio
incorrectly fired HUP events. This was due to Mio mapping
RDHUPtoHUP. The test is updated to correctly generate a HUP event.
Additionally, HUP events will be removed from all platforms except for
Linux. This is caused by the inability to reliably map kqueue events to
the epoll HUP behavior.