Backport to 0.1: Shared must relinquish control to the executor if repolled #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…polled This backports rust-lang#2136 to Futures 0.1. There isn't much to add on top of what's mentioned in rust-lang#2136: the same bug exists in Futures 0.1, and it'll fail in the same way when polled in recent versions of Tokio (rust-lang#2418). Backporting to 0.1 allows codebases that still have some Futures 0.1 code around to still use newer versions of Tokio.
|
Any thoughts? :) |
|
#2122 hasn't been released yet, so it's nice to publish the next release of 0.1 after merging this. (We need to decide how long we should maintain 0.1 branch, but this should be fine given that we have another backport already merged.) |
taiki-e
approved these changes
Jul 20, 2020
|
Could we get this merged and released? Having futures 0.1 being broken on newer versions of Tokio makes upgrading Tokio more painful than it should be :( |
|
Thanks, I'll prepare the next release. |
|
Thanks a lot @taiki-e ! |
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Sep 9, 2020
Summary: We are using older version of tokio which spawns as many threads as we have physical cores instead of the number of logical cores. It was fixed in tokio-rs/tokio#2269 but we can't use it yet because we are waiting for another fix to be released - rust-lang/futures-rs#2154. For now let's hardcode it in mononoke Reviewed By: krallin Differential Revision: D23599140 fbshipit-source-id: 80685651a7a29ba8938d9aa59770f191f7c42b8b
|
Hey @taiki-e , I'm sorry to be a bit of a bother here, but has this made it into a new release yet? Thanks :) |
Merged
|
Published 0.1.30, sorry for the delay. |
|
Thanks very much!
…On Mon, 5 Oct 2020 at 17:55, Taiki Endo ***@***.***> wrote:
Published 0.1.30, sorry for the delay.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2154 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANIHVQJLTYFPESWHHN7PODSJH27HANCNFSM4M7RLPPQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #2136 to Futures 0.1. There isn't much to add on top of
what's mentioned in #2136: the same bug exists in Futures 0.1, and it'll
fail in the same way when polled in recent versions of Tokio (#2418).
Backporting to 0.1 allows codebases that still have some Futures 0.1
code around to still use newer versions of Tokio.