Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use only_hack_old_rustc for proc_macro_hack #2243

Merged
merged 2 commits into from
Oct 28, 2020
Merged

use only_hack_old_rustc for proc_macro_hack #2243

merged 2 commits into from
Oct 28, 2020

Conversation

ordian
Copy link
Contributor

@ordian ordian commented Oct 28, 2020 •
edited by taiki-e
Loading

@taiki-e taiki-e self-requested a review October 28, 2020 18:18
taiki-e
taiki-e approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! only_hack_old_rustc may cause breakage related to hygiene, but hopefully it will only give us a few new warnings and will not cause compile failures.

@taiki-e taiki-e merged commit 4122f3d into rust-lang:master Oct 28, 2020
This was referenced Oct 28, 2020
Closed
Merged
@taiki-e taiki-e added the A-macro Area: macro related label Jan 6, 2021
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
A-macro Area: macro related
Projects
None yet
Milestone
No milestone
2 participants
@ordian @taiki-e