Override Debug for oneshot::{Sender,Receiver}. #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this diff, the Debug impl for oneshot channels printed something like:
```
Sender { inner: Inner { complete: false, data: Lock { locked: false, data: UnsafeCell }, rx_task: Lock { locked: false, data: UnsafeCell }, tx_task: Lock { locked: false, data: UnsafeCell } } }
```
which isn't very helpful. Instead, just print
`Sender { complete: false }` (or `true`, if the other end has dropped).
Note that the `T: Debug` bound is retained to allow for the possibility
of allowing slightly more interesting debug output in the future.
|
Some users may want the detailed debug information. It could be particularly helpful for debugging deadlocks. |
|
A user can't actually lock the internal locks themselves, so if there were a deadlock it would be a bug internal to futures-rs. |
taiki-e
added
A-channel
Merged
taiki-e
added
0.3-backport: completed
and removed
0.3-backport: pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this diff, the Debug impl for oneshot channels printed something like:
which isn't very helpful. Instead, just print
Sender { complete: false }(ortrue, if the other end has dropped).Note that the
T: Debugbound is retained to allow for the possibilityof allowing slightly more interesting debug output in the future.