linux_like: unify SIGEV_THREAD_ID support #3661
Open
+6
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
christoph-heiss
force-pushed
the
musl-sigev-thread-id
branch
3 times, most recently
from
2fd26c6
to
1c292ff
Compare
JohnTitor
approved these changes
Apr 19, 2024
|
(Should be merged after we upgrade musl header on CI). |
christoph-heiss
force-pushed
the
musl-sigev-thread-id
branch
from
1c292ff
to
bddd7aa
Compare
christoph-heiss
force-pushed
the
musl-sigev-thread-id
branch
from
bddd7aa
to
01829ec
Compare
For reference, should be mergeable after this PR: #3068. |
|
@rustbot blocked |
This effectively adds the constant for musl too, as last platform of
this category.
It has been supported in musl since
7c71792e ("add support for SIGEV_THREAD_ID timers")
and was released with v1.2.2 in January 2021.
Also double-checked that the `sigevent` struct is defined in the exact
same way.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
christoph-heiss
force-pushed
the
musl-sigev-thread-id
branch
from
01829ec
to
9272dc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been supported in musl since release v1.2.2 in January 2021. See also the commit in musl itself.
Not sure about emscripten though - I guess without gating it, it would be enabled there too?
As this is my first contribution, please just holler if something is off.