Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cargo fix --edition on x86_64-unknown-linux-gnu #4132

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eduardosm
Copy link
Contributor

Description

This is the result of running cargo fix --edition on x86_64-unknown-linux-gnu, with some minor manual adjustments.

Cargo.toml still has edition 2015 since there are many other targets whose modules needs conversion.

Since ctest2 does not support crate:: in paths, a hack has been implemented in libc-test/build.rs, which makes a copy of src replacing every crate:: with ::.

cc #3898

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Nov 21, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@bors
Copy link
Contributor

bors commented Nov 21, 2024

☔ The latest upstream changes (presumably #4128) made this pull request unmergeable. Please resolve the merge conflicts.

@eduardosm
Copy link
Contributor Author

eduardosm commented Nov 21, 2024

  called `Result::unwrap()` on an `Err` value: Os { code: 30, kind: ReadOnlyFilesystem, message: "Read-only file system" }

Is the whole working copy read-only except target?

EDIT: It is.

libc/ci/run-docker.sh

Lines 50 to 51 in 01c7a63

--volume "$(pwd)":/checkout:ro \
--volume "$(pwd)"/target:/checkout/target \

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants