Combined CI fixes #3797
Combined CI fixes #3797
Conversation
These targets seem to regularly break unrelated PRs, and in general we shouldn't gate PRs on tier 3 targets (per the target tier policy).
- CI only for macOs arm64. - Fixing build issues for macOs arm64. - Adding macos cpu to arch api.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
|
Hm, still a MacOS failure. |
|
The failure at https://github.com/rust-lang/libc/actions/runs/10310339998/job/28541913762?pr=3797 seems to be from the changes to the rust-lang/rust workspaces. The fix was merged yesterday so should be available on today's nightly, which will be available in a couple hours. Will retry the job then and merge if it succeeds. Edit: didn't work :( |
|
I guess the fix was merged yesterday rust-lang/cargo#14370, but the update to rust-lang/rust just missed the cutoff for the most recent nightly rust-lang/rust#128827 (comment). ~10 hours to get a newer nightly and try again. |
|
Got the new nightly, but it looks like there is a new duplicate symbol failure. |
|
Each day libc CI crashes in a creative, fun, but always in a different way... |
|
Looks like it's failing on the hexagon build test. I haven't dug into it yet but I think the builtins hexagon asm could be defining symbols that are now redundantly included as weak math intrinsics. Going to disable that with a FIXME for now so we don't have another cycle of updating builtins and getting a new nightly. This is a tier 3 target so there should be no problems here. |
`compiler-builtins` seems to be providing duplicate symbols on Hexagon. This may be because some symbols have always been defined in assembly, but are now also provided by the weak math symbols. The fix for this is probably to not provide any math symbols on Hexagon that would duplicate the assembly version. However, to avoid going through another nightly release cycle, disable it temporarially instead. Link: rust-lang#3797 (comment)
tgross35
added
the
stable-nominated
These targets seem to regularly break unrelated PRs, and in general we shouldn't gate PRs on tier 3 targets (per the target tier policy). (backport <rust-lang#3797>) (cherry picked from commit be1c8e5)
These targets seem to regularly break unrelated PRs, and in general we shouldn't gate PRs on tier 3 targets (per the target tier policy). (backport <rust-lang#3797>) (cherry picked from commit be1c8e5)
(backport <rust-lang#3797>) (cherry picked from commit 147222d)
`compiler-builtins` seems to be providing duplicate symbols on Hexagon. This may be because some symbols have always been defined in assembly, but are now also provided by the weak math symbols. The fix for this is probably to not provide any math symbols on Hexagon that would duplicate the assembly version. However, to avoid going through another nightly release cycle, disable it temporarially instead. Link: rust-lang#3797 (comment) (backport <rust-lang#3797>) (cherry picked from commit 77e9d06)
tgross35
added
stable-applied
Combine the following to fix CI in one go:
Once this succeeds, we can cherry pick to the 0.2 branch.