Skip to content

[0.2] Combined CI fixes #3806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 12, 2024
Merged

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Aug 12, 2024

Backport #3797

These targets seem to regularly break unrelated PRs, and in general we
shouldn't gate PRs on tier 3 targets (per the target tier policy).

(backport <rust-lang#3797>)
(cherry picked from commit be1c8e5)
@rustbot
Copy link
Collaborator

rustbot commented Aug 12, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35 tgross35 changed the title Remove tier 3 targets from CI [0.2] Combined CI fixes Aug 12, 2024
(backport <rust-lang#3797>)
(cherry picked from commit 147222d)
@tgross35 tgross35 enabled auto-merge August 12, 2024 21:47
`compiler-builtins` seems to be providing duplicate symbols on Hexagon.
This may be because some symbols have always been defined in assembly,
but are now also provided by the weak math symbols.

The fix for this is probably to not provide any math symbols on Hexagon
that would duplicate the assembly version. However, to avoid going
through another nightly release cycle, disable it temporarially instead.

Link: rust-lang#3797 (comment)
(backport <rust-lang#3797>)
(cherry picked from commit 77e9d06)
@tgross35 tgross35 disabled auto-merge August 12, 2024 22:01
@tgross35 tgross35 enabled auto-merge August 12, 2024 22:01
@tgross35 tgross35 added this pull request to the merge queue Aug 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2024
@tgross35 tgross35 added this pull request to the merge queue Aug 12, 2024
Merged via the queue into rust-lang:libc-0.2 with commit c27c43f Aug 12, 2024
51 checks passed
@tgross35 tgross35 deleted the backport-ci-fixes branch August 12, 2024 23:51
@tgross35 tgross35 mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants